Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Use playwright electron module for e2e testing #888

Merged
merged 29 commits into from
Feb 12, 2025
Merged

[Test] Use playwright electron module for e2e testing #888

merged 29 commits into from
Feb 12, 2025

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Feb 11, 2025 •
edited
Loading

Changes

  • Removes vite dev server workarounds from e2e testing
  • Launches the app as an executable, via playwright's Electron API

Testing

  • Testing is currently sequential; most/all parallel testing will require sharding
  • New test framework is easily extended
  • Test objects are disposable and currently perform async clean up per-test

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested review from a team as code owners February 11, 2025 13:08
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 11, 2025
@webfiltered
Backup local user config on global setup
be7f239
@webfiltered
Set more realistic timeouts
97a812c
@webfiltered
Refactor TestApp to base class
893cbdc
@webfiltered
Split app window tests to separate file
70f9f82
@webfiltered
Add self-cleaning test app class to run installation tests
d61a475
@webfiltered
Add basic testing README
36b1973
@webfiltered
Update terminology - now using e2e testing
fbe148b
@webfiltered
Include playwright reports in GH action artifacts
6e23b24
@webfiltered
Add Playwright reporting
4366366
@webfiltered
Use default expect timeout
c8eab76
@webfiltered
Capture trace, screenshots, and video in CI
e0f7b3e
@webfiltered
Fix workflow - default Playwright output dir
3afa0b7
@webfiltered
Add log upload
e573021
@webfiltered
Add screenshot on app start
6896f67
@webfiltered
nit - Add step names
724a333
@webfiltered
Copy log file location from runner shell to GH env
a41d8d0
@webfiltered
Fix GH action syntax
15000a4
@webfiltered
Attach desktop app logs before resetting appdata
b31e31e
@webfiltered
Fix throw when log missing
2fe6e1c
@webfiltered
Add app startup timeout
9440da9
@webfiltered
Use debug log level in e2e tests
e18576f
@webfiltered
Add test screenshot
7cc1afe
@webfiltered
Allow env vars to be passed into tested app
f5e8719
@webfiltered
Prefer Playwright attach to GH action upload
f13f409
@webfiltered
nit
95f382a
@webfiltered webfiltered merged commit ef25f7b into main Feb 12, 2025
7 checks passed
@webfiltered webfiltered deleted the end-to-end branch February 12, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webfiltered